Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Night Vision #1554

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Fix Night Vision #1554

merged 5 commits into from
Jan 15, 2025

Conversation

Piras314
Copy link
Contributor

@Piras314 Piras314 commented Jan 15, 2025

Description

Fixes the bug where you could put a mouse on your head and get free night vision. This works by adding a bool to the SwitchableVisionOverlayComponent IsEquipment that will be checked for before granting the thermal/night vision action. Port of Goob-Station/Goob-Station#1448


Media

No night vision with the mouse on your head:
image

Goggles still work:
image


Changelog

🆑 Piras314, Aviu

  • fix: Fixed being able to get night vision from putting a mouse on your head.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 15, 2025
@Piras314
Copy link
Contributor Author

checkfail seems to be unrelated

Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really simple fix for the bug, as funny as the bug was we kind of did need to yeet it.

@VMSolidus VMSolidus merged commit 03b7a8a into Simple-Station:master Jan 15, 2025
10 of 11 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants